Preserve order in left join for cudf-polars #16268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
wence-
added
improvement
wence-
force-pushed
the
wence/fea/polars-left-join-order
branch
from
a89561e
to
7bd3aa5
Compare
python/cudf/cudf/_lib/pylibcudf/libcudf/utilities/type_dispatcher.pxd
Outdated
Show resolved
Hide resolved
Instead use new exposed pylibcudf SIZE_TYPE_ID.
We can use the constructor that takes an && reference to a device_uvector. This means we don't accidentally overflow size_type if the gather map is too large for a column, and avoids hardcoding the type id for the entries.
wence-
force-pushed
the
wence/fea/polars-left-join-order
branch
from
8a86fd2
to
652276b
Compare
|
Fixed merge conflicts, ready for another look. |
vyasr
approved these changes
Jul 19, 2024
vyasr
reviewed
Jul 19, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unlike all other joins, polars provides an ordering guarantee for left joins. By default libcudf does not, so we need to order the gather maps in this case.
While here, because it requires another hard-coding of
int32for something that should besize_type, exposetype_to_idin cython and plumb it through.Checklist