Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace is_datetime/timedelta_dtype checks with .kind checks #16262

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Replace is_datetime/timedelta_dtype checks with .kind checks #16262

merged 6 commits into from
Jul 16, 2024

Conversation

mroeschke
Copy link
Contributor

Description

It appears this was called when we already had a dtype object so can instead just simply check the .kind attribute

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 11, 2024
@mroeschke mroeschke requested a review from a team as a code owner July 11, 2024 22:42
@mroeschke mroeschke requested review from wence- and bdice July 11, 2024 22:42
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit dba46e7 into rapidsai:branch-24.08 Jul 16, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mroeschke @vyasr