Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with CUDA 12.5.1 #16259

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 11, 2024

This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.

Contributes to rapidsai/build-planning#73

@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 11, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review July 16, 2024 13:27
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners July 16, 2024 13:27
@jameslamb jameslamb requested review from jameslamb and removed request for raydouglass July 16, 2024 15:02
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one other place that needs to be updated:

conda env create --name cudf_dev --file conda/environments/all_cuda-122_arch-x86_64.yaml

Since the name of the conda env file checked into conda/environments is changing (-122 to -125), mentions of it in docs need to change.

Many of the RAPIDS projects have similar lines in their docs that describe using the files in conda/environments for local development (although of the ones I've looked at today, most are still using the CUDA 11.8 env), so I think it'd be worth adding this to the rapids-reviser migration script so such things aren't missed the next time we do an update like this.

how I found this

I've been doing the following while reviewing these CUDA 12.5 PRs:

# look for other uses of CUDA 12.2
git grep -E '12\.2'

# look for references to the conda env files
git grep -E 'all_cuda'
git grep -E '\-122'

@KyleFromNVIDIA
Copy link
Contributor Author

I've updated https://github.com/rapidsai/rapids-reviser/pull/42 to update conda environments and docs, updated this PR, and also updated rapidsai/cugraph#4534.

@jakirkham jakirkham requested a review from jameslamb July 16, 2024 16:20
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e2b7e43 into rapidsai:branch-24.08 Jul 16, 2024
78 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyleFromNVIDIA This directory needs to be renamed from 12.2 to 12.5. Maybe we can get by with just one devcontainer per major version, and use only “11” and “12”? Perhaps that would be worth discussing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

We missed this on review. Sorry about that

Have simply renamed in PR: #16293 (this is what we needed to do in a couple other places already)

We can discussing renaming separately. Would want to hear from Paul on that

rapids-bot bot pushed a commit that referenced this pull request Jul 17, 2024
Follow up to PR: #16259
Partially addresses issue: rapidsai/build-planning#73

Renames the `.devcontainer`s for CUDA 12.5

Authors:
  - https://github.com/jakirkham

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Paul Taylor (https://github.com/trxcllnt)

URL: #16293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants