Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contains_tests.cpp to use public cudf::slice #16253

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Update contains_tests.cpp to use public cudf::slice #16253

merged 1 commit into from
Jul 12, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Changes the cpp/tests/lists/contains_test.cpp to use cudf::slice instead of cudf::detail::slice()

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 11, 2024
@davidwendt davidwendt self-assigned this Jul 11, 2024
@davidwendt davidwendt requested a review from a team as a code owner July 11, 2024 16:56
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1cbd9eb into rapidsai:branch-24.08 Jul 12, 2024
80 checks passed
@davidwendt davidwendt deleted the contains-test-detail branch July 12, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@bdice bdice bdice approved these changes

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidwendt @robertmaynard @bdice @mhaseeb123