Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary functor overloads required by cuco version bump #16242

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Remove temporary functor overloads required by cuco version bump #16242

merged 1 commit into from
Jul 12, 2024

Conversation

PointKernel
Copy link
Member

Description

This is a follow-up of #15938. It removes the temporary workaround no longer needed after the cuco version bump.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 3 - Ready for Review Ready for review by team labels Jul 10, 2024
@PointKernel PointKernel marked this pull request as ready for review July 10, 2024 19:42
@PointKernel PointKernel requested a review from a team as a code owner July 10, 2024 19:42
@PointKernel PointKernel self-assigned this Jul 10, 2024
bdice
bdice approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All negative PRs got me like

image

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 99ad73d into rapidsai:branch-24.08 Jul 12, 2024
79 checks passed
@PointKernel PointKernel deleted the remove-temporary-overloads branch July 12, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@davidwendt davidwendt davidwendt approved these changes

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@PointKernel PointKernel

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PointKernel @bdice @davidwendt