Make etc/clean.py python 2/3 compatible #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
reviewed
Apr 30, 2019
| for file in files: | ||
| if file.endswith('.pyc') \ | ||
| or file.endswith('~') \ | ||
| or file.endswith('.pyo'): | ||
| count += 1 | ||
| os.remove(os.path.join(name, file)) | ||
| for folder in folders: |
There was a problem hiding this comment.
do we need to do this in addition to deleting the .pyc files inside these directories?
There was a problem hiding this comment.
Yes. Python 3 saves .pyc files in __pycache__ dirs.
| import os | ||
|
|
||
|
|
||
| def main(): | ||
| path = '.' | ||
| count = 0 | ||
| for name, folders, files in os.walk(path): | ||
| for name, folders, files in os.walk(path, topdown=False): |
There was a problem hiding this comment.
what's the topdown arg for here?
There was a problem hiding this comment.
It is used so that *.pyc files would be deleted from __pycache__ before we try to delete these directories using os.rmdir() (thus the dirs are preserved if they unexpected files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.