Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include "examples" directory in the sdist again #1982

Open
wants to merge 1 commit into
base: 3.1.x
Choose a base branch
from

Conversation

dne
Copy link

@dne dne commented May 19, 2024

When moving to flit from setuptools, the "examples" directory was lost from the source distribution. I'm assuming that this was unintentional, since pyproject.toml on the main branch still includes it.

Fixes regression introduced in #1968.

When moving to flit from setuptools, in pallets#1968, the "examples"
directory was lost from the source distribution.
@davidism
Copy link
Member

Thanks, but I don't think we need to include them. The examples aren't part of the code docs or tests (and those last two don't technically need to be there either).

@dne
Copy link
Author

dne commented May 19, 2024

Sure, they're not strictly necessary, but they've been part of the sdist since version 2.0 up until 3.1.3. And, as I mentioned, this regression seems specific for the 3.1.x branch.

FWIW, I discovered this when packaging 3.1.4 for Alpine Linux, which installs the examples as part of the "doc" sub-package (and so does e.g. Debian apparently)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants