8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F #20608

TejeshR13 · 2024-08-16T07:39:44Z

In JTable, keyboard navigation keys Ctrl Shift RIGHT/LEFT doesn't follow native actions of Linux. In native the actions are extended to end of selected columns cells either LEFT/RIGHT but in swing gtk look and feel the selection is extended to one cell to left/right. This might be taken as reference of Windows OS since the same is observed in Windows native. Hence I have update the actions for Ctrl Shift RIGHT & LEFT.
Added automated test too. The fix is tested in CI and its fine.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F (Bug - P4)

Reviewers

Harshitha Onkar (@honkar-jdk - Reviewer)
Phil Race (@prrace - Reviewer)
Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20608/head:pull/20608
$ git checkout pull/20608

Update a local copy of the PR:
$ git checkout pull/20608
$ git pull https://git.openjdk.org/jdk.git pull/20608/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20608

View PR using the GUI difftool:
$ git pr show -t 20608

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20608.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-08-16T07:40:36Z

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-08-16T07:41:40Z

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F

Reviewed-by: honkar, prr, abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

5671f83: 8338785: The java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY field is not used
32b3d70: 8338925: ProblemList runtime/interpreter/LastJsrTest.java on linux-all
5d12ac3: 8337715: Update --release 23 symbol information for JDK 23 build 37
23dc3b0: 8324048: (fc) Make FileKey fields final
a461369: 8338700: AttributeMapper type parameter should be bounded by Attribute
916f1aa: 8329756: [macos] "javax/swing/JTable/KeyBoardNavigation.java" fail because most combinations of navigational keys with the Ctrl key do not work
21d1e4d: 8338819: JFR: Internal events causes crash when no other events are in use
965dd1a: 8333334: C2: Make result of Node::dominates more precise to enhance scalar replacement
69bd227: 8338417: Explicitly pin a virtual thread before acquiring the JFR string pool monitor
fead3cf: 8338745: Intrinsify Continuation.pin() and Continuation.unpin()
... and 40 more: https://git.openjdk.org/jdk/compare/9775d57168695dc0d758e017fe5069d93d593f3e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-08-16T07:42:07Z

@TejeshR13 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-08-16T07:45:07Z

Webrevs

01: Full - Incremental (8c436fdd)
00: Full (ab34edf8)

test/jdk/javax/swing/plaf/gtk/JTableCtrlShiftRightLeftKeyTest.java

DamonGuy

The change itself works fine. I agree with the test changes submitted already. Out of curiosity, what native app did you compare it to when you checked for native behavior?

DamonGuy · 2024-08-19T16:51:35Z

Also probably worth fixing the Keyborad typo in the title and JBS issue to Keyboard.

prrace · 2024-08-19T20:50:08Z

Also probably worth fixing the Keyborad typo in the title and JBS issue to Keyboard.

That was the first thing I noticed about this PR :-). I fixed the JBS issue.

TejeshR13 · 2024-08-20T05:06:44Z

The change itself works fine. I agree with the test changes submitted already. Out of curiosity, what native app did you compare it to when you checked for native behavior?

Libre.

…_8338041

test/jdk/javax/swing/plaf/gtk/JTableCtrlShiftRightLeftKeyTest.java

honkar-jdk

Fix looks good and works similar to native app - Libre Calc on linux.

alisenchung · 2024-08-22T21:24:50Z

src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java

@@ -1058,15 +1058,15 @@ public Object createValue(UIDefaults table) {
 "KP_RIGHT", "selectNextColumn",
 "shift RIGHT", "selectNextColumnExtendSelection",
 "shift KP_RIGHT", "selectNextColumnExtendSelection",
- "ctrl shift RIGHT", "selectNextColumnExtendSelection",
+ "ctrl shift RIGHT", "selectLastColumnExtendSelection",
 "ctrl shift KP_RIGHT", "selectNextColumnExtendSelection",


should KP_RIGHT also be changed to selectLastColumnExtendSelection? Should keypad shortcuts be identical to the arrow key shortcuts?

Good catch.

Actually all KP shortcuts are miss aligned with native. So I thought of handling it separately.

alisenchung · 2024-08-22T21:25:00Z

src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java

 "ctrl shift KP_RIGHT", "selectNextColumnExtendSelection",
 "ctrl RIGHT", "selectNextColumnChangeLead",
 "ctrl KP_RIGHT", "selectNextColumnChangeLead",
 "LEFT", "selectPreviousColumn",
 "KP_LEFT", "selectPreviousColumn",
 "shift LEFT", "selectPreviousColumnExtendSelection",
 "shift KP_LEFT", "selectPreviousColumnExtendSelection",
- "ctrl shift LEFT", "selectPreviousColumnExtendSelection",
+ "ctrl shift LEFT", "selectFirstColumnExtendSelection",
 "ctrl shift KP_LEFT", "selectPreviousColumnExtendSelection",


here as well

kumarabhi006

Looks good to me now.

TejeshR13 · 2024-08-28T04:41:34Z

/integrate

openjdk · 2024-08-28T04:43:12Z

Going to push as commit 8e88da0.
Since your change was applied there have been 78 commits pushed to the master branch:

449ca2c: 8337832: Optimize datetime toString
b1b4cd4: 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java
284c3cd: 8336299: Improve GCLocker stall diagnostics
2e96f15: 8338489: Typo in MemorySegment doc
44d3a68: 8314124: RISC-V: implement Base64 intrinsic - decoding
daf2617: 8338929: Make Metaspace::deallocate space-aware
fa4ff78: 8338690: CompactNumberInstance.format incorrectly formats some numbers (few vs many)
1ff5f8d: 8338440: Parallel: Improve fragmentation mitigation in Full GC
0f66710: 8338939: Simplify processing of hidden class names
b25095b: 8338728: Misc issues in memory layout javadoc
... and 68 more: https://git.openjdk.org/jdk/compare/9775d57168695dc0d758e017fe5069d93d593f3e...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-08-28T04:43:18Z

@TejeshR13 Pushed as commit 8e88da0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

TejeshR13 added 2 commits August 13, 2024 13:51

Key action modified + Automatic test added

0262efb

Test updates

ab34edf

openjdk bot added the rfr Pull request is ready for review label Aug 16, 2024

openjdk bot added the client [email protected] label Aug 16, 2024

kumarabhi006 reviewed Aug 16, 2024

View reviewed changes

DamonGuy reviewed Aug 19, 2024

View reviewed changes

TejeshR13 changed the title ~~8338041: Keyborad Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F~~ 8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F Aug 20, 2024

TejeshR13 added 2 commits August 20, 2024 12:17

Merge branch 'master' of https://git.openjdk.java.net/jdk into branch…

4da316a

…_8338041

Updated review comments

8c436fd

honkar-jdk reviewed Aug 22, 2024

View reviewed changes

test/jdk/javax/swing/plaf/gtk/JTableCtrlShiftRightLeftKeyTest.java Show resolved Hide resolved

honkar-jdk reviewed Aug 22, 2024

View reviewed changes

honkar-jdk approved these changes Aug 22, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 22, 2024

alisenchung reviewed Aug 22, 2024

View reviewed changes

prrace approved these changes Aug 23, 2024

View reviewed changes

kumarabhi006 approved these changes Aug 26, 2024

View reviewed changes

prrace approved these changes Aug 27, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Aug 28, 2024

openjdk bot closed this Aug 28, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F #20608

8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F #20608

TejeshR13 commented Aug 16, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Aug 16, 2024

openjdk bot commented Aug 16, 2024 •

edited

Loading

openjdk bot commented Aug 16, 2024

mlbridge bot commented Aug 16, 2024 •

edited

Loading

DamonGuy left a comment

DamonGuy commented Aug 19, 2024

prrace commented Aug 19, 2024

TejeshR13 commented Aug 20, 2024

honkar-jdk left a comment

alisenchung Aug 22, 2024

honkar-jdk Aug 22, 2024

TejeshR13 Aug 23, 2024 •

edited

Loading

alisenchung Aug 22, 2024

kumarabhi006 left a comment

TejeshR13 commented Aug 28, 2024

openjdk bot commented Aug 28, 2024

openjdk bot commented Aug 28, 2024

8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F #20608

8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F #20608

Conversation

TejeshR13 commented Aug 16, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Aug 16, 2024

openjdk bot commented Aug 16, 2024 • edited Loading

openjdk bot commented Aug 16, 2024

mlbridge bot commented Aug 16, 2024 • edited Loading

Webrevs

DamonGuy left a comment

Choose a reason for hiding this comment

DamonGuy commented Aug 19, 2024

prrace commented Aug 19, 2024

TejeshR13 commented Aug 20, 2024

honkar-jdk left a comment

Choose a reason for hiding this comment

alisenchung Aug 22, 2024

Choose a reason for hiding this comment

honkar-jdk Aug 22, 2024

Choose a reason for hiding this comment

TejeshR13 Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

alisenchung Aug 22, 2024

Choose a reason for hiding this comment

kumarabhi006 left a comment

Choose a reason for hiding this comment

TejeshR13 commented Aug 28, 2024

openjdk bot commented Aug 28, 2024

openjdk bot commented Aug 28, 2024

TejeshR13 commented Aug 16, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Aug 16, 2024 •

edited

Loading

mlbridge bot commented Aug 16, 2024 •

edited

Loading

TejeshR13 Aug 23, 2024 •

edited

Loading