8338469: com/sun/jdi/DataDumpTest.java failed with Not a debuggee, or not listening for debugger to attach

[plummercj]

There are issues with the test attaching to the debuggee too soon, and the debug agent isn't ready. yet. This test is based on ProcessAttachTest, which does not have this issue. I eventually realized the reason why is because ProcessAttachTest has this little snippet of code, which I had removed from DataDumpTest:

         // Wait for the process to start
        InputStream is = p.getInputStream();
        is.read(); 

This is waiting for the start of the debug agent's "Listening..." message. I've re-added this to DataDumpTest, and it seems to fix the issue. Tested by running 20 times with -Xcomp on all supported platforms with no failures. It used to fail about 2/3 of the time.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8338469: com/sun/jdi/DataDumpTest.java failed with Not a debuggee, or not listening for debugger to attach (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20604/head:pull/20604
$ git checkout pull/20604

Update a local copy of the PR:
$ git checkout pull/20604
$ git pull https://git.openjdk.org/jdk.git pull/20604/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20604

View PR using the GUI difftool:
$ git pr show -t 20604

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20604.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bf3b1617)