8334234: NMT: Re-evaluate MallocMemory and VirtualMemory counter classes

[roberttoyonaga]

Summary

This PR splits up NMT memory counter classes into "live" and "flat" versions. Currently, the same classes are used and reused in both live (recording) and snapshotted (reporting) contexts. However, after counters have been shapshotted, they no longer need to be atomic or require things like peak updating. "Live" classes are now atomic and have methods needed for recording allocation/dealocation and updating peaks. "Flat" classes basically just hold data to later be reported, are not atomic, and only have methods for retrieving data.

I've also made all counters in LiveVirtualMemory update atomically, when previously only the peaks in VirtualMemory were updated atomically.

Testing

• tier1
• jdk/test/hotspot/jtreg/gtest/NMTGtests.java
• jdk/test/jdk/jdk/jfr/event/runtime/TestNativeMemoryUsageEvents.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334234: NMT: Re-evaluate MallocMemory and VirtualMemory counter classes (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20550/head:pull/20550
$ git checkout pull/20550

Update a local copy of the PR:
$ git checkout pull/20550
$ git pull https://git.openjdk.org/jdk.git pull/20550/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20550

View PR using the GUI difftool:
$ git pr show -t 20550

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20550.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@roberttoyonaga To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[roberttoyonaga]

/label serviceability

[openjdk]

@roberttoyonaga
The serviceability label was successfully added.

[roberttoyonaga]

Hi @tstuefe, can you please have a look through this when you have time?

[mlbridge]

Webrevs

• 00: Full (949a3734)

[bridgekeeper]

@roberttoyonaga This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[roberttoyonaga]

Commenting to prevent this from being closed in 4 weeks.