Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaletteDialog: replace apply with restore defaults #184

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

pvmm
Copy link
Contributor

@pvmm pvmm commented Jun 8, 2023

image

Now the palette editor allows the user to restore palette to the default MSX palette. Apply is not as useful as the Defaults button, so it was removed to reduce clutter.

Copy link
Contributor

@m9710797 m9710797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

This PR is fine. I'll merge it.
I do have one remark, but it's about the existing code, not about your changes:

BitMapViewer and TileViewer each have a global variable 'currentPalette'. In general global (non-const) variables should be avoided. So maybe these should be made member variables of the BitMapViewer/TileViewer classes?

I also wonder why BitMapViewer and TileViewer each have their own 'currentPalette' array, Maybe this should be a shared array? (Because even if you use a custom palette rather than the current VDP palette, I assume it's useful to have the same custom palette between BitMapViewer and TileViewer)

@m9710797 m9710797 merged commit 543e1c9 into openMSX:master Jun 8, 2023
@pvmm
Copy link
Contributor Author

pvmm commented Jun 8, 2023

I also wonder why BitMapViewer and TileViewer each have their own 'currentPalette' array, Maybe this should be a shared array? (Because even if you use a custom palette rather than the current VDP palette, I assume it's useful to have the same custom palette between BitMapViewer and TileViewer)

Then maybe store it in VDPDataStore and call it alternativePalette.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants