Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix futex support on OpenBSD #1499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Aug 29, 2024

Description

OpenBSD no longer supports direct syscalls.

openbsd/src@cafeb89

Type of change

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

@pavelkumbrasev
Copy link
Contributor

Please correct the copyright year

@akukanov
Copy link

@pavelkumbrasev Are systems that do not have futex still in support? If not, it might make sense to keep only the new implementation. Or maybe replace the check for OpenBSD with a check for presence of futex if such can be made.

@pavelkumbrasev
Copy link
Contributor

@pavelkumbrasev Are systems that do not have futex still in support?

That's a good question we have never discussed this specific requirement: #if defined(SYS_futex)

@brad0
Copy link
Contributor Author

brad0 commented Aug 30, 2024

That's a good question we have never discussed this specific requirement: #if defined(SYS_futex)

@pavelkumbrasev I was looking at that and although that does apply for OpenBSD at the moment that isn't necessarily the case in the future.

@brad0
Copy link
Contributor Author

brad0 commented Sep 3, 2024

@pavelkumbrasev Let me know if updating the copyright alone is Ok or if you want to go in some other direction based off of this.

@pavelkumbrasev
Copy link
Contributor

Since futex is still present on the OS I think this approach is fine. The only question: will this approach affect older versions of OpenBSD or it will work just fine?
(Copyright year should be fixed)

@brad0
Copy link
Contributor Author

brad0 commented Sep 3, 2024

Since futex is still present on the OS I think this approach is fine. The only question: will this approach affect older versions of OpenBSD or it will work just fine? (Copyright year should be fixed)

It is fine for any version of OpenBSD that has futex support, 14 releases.

OpenBSD no longer supports direct syscalls.

openbsd/src@cafeb89
@brad0
Copy link
Contributor Author

brad0 commented Sep 9, 2024

@pavelkumbrasev Ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants