feat(core): add option to have router module path before version #13288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using
RouterModule
along with URI versioning, you cannot affect the order of path parts. It is always like this:/{globalAppPrefix}/{version}/{modulePath}/{controllerPath}/{methodPath}
I'm using
RouterModule
to separate public facing and internal routes like this:So my routes are
/api/public/...
and/api/internal/...
.When I enable URI versioning my routes are
/api/v1/public/...
and/api/v1/internal/...
which breaks my proxy which enables any requests starting with/api/public/*
to pass in.Issue Number: N/A
What is the new behavior?
After adding
pathBeforeVersion: true
, the module path and version parts are swapped like so:/{globalAppPrefix}/{modulePath}/{version}/{controllerPath}/{methodPath}
My routes are now
/api/public/v1/...
and/api/internal/v1/...
and my proxy still works.Setting the
pathBeforeVersion: false
or omitting the parameter doesn't introduce any change.Does this PR introduce a breaking change?
Other information