Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add support for configurable configuration nodes in new canvas (no-changelog) #9991

Merged

Conversation

alexgrozav
Copy link
Contributor

Summary

Screenshot 2024-07-10 at 08 47 32

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7494/add-support-for-configurable-configuration-nodes

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Jul 10, 2024
@alexgrozav alexgrozav changed the title N8n 7494 add support for configurable configuration nodes feat(editor): Add support for configurable configuration nodes in new canvas (no-changelog) Jul 10, 2024
@alexgrozav alexgrozav force-pushed the n8n-7494-add-support-for-configurable-configuration-nodes branch from cfde1ac to 50e36f7 Compare July 10, 2024 07:26
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 10, 2024
Copy link

cypress bot commented Jul 10, 2024

3 flaky tests on run #5866 ↗︎

0 399 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: 1652081524
Status: Passed Duration: 05:12 💡
Started: Jul 10, 2024 2:45 PM Ended: Jul 10, 2024 2:50 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should auto load more items if there is space and auto scroll Test Replay Screenshots Video

Review all test suite changes for PR #9991 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit a458997 into master Jul 10, 2024
27 checks passed
@alexgrozav alexgrozav deleted the n8n-7494-add-support-for-configurable-configuration-nodes branch July 10, 2024 14:51
@janober
Copy link
Member

janober commented Jul 10, 2024

Got released with [email protected]

jeanpaul pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants