Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update aliases for file nodes (no-changelog) #10028

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jul 12, 2024

Summary

Updates codex files for file nodes.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1499/extract-from-file-node-add-extra-aliases

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jul 12, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

cypress bot commented Jul 12, 2024

3 flaky tests on run #5906 ↗︎

0 400 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 2ca23024c6
Status: Passed Duration: 04:55 💡
Started: Jul 12, 2024 10:30 AM Ended: Jul 12, 2024 10:35 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video

Review all test suite changes for PR #10028 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 4aa60c6 into master Jul 12, 2024
27 checks passed
@Joffcom Joffcom deleted the node-1499-extract-from-file-node-add-extra-aliases branch July 12, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants