Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add ability to add a node between two nodes in new canvas (no-changelog) #10006

Conversation

alexgrozav
Copy link
Contributor

Summary

Screen.Recording.2024-07-11.at.12.20.28.mov

Known issues:

  • Insert position is sometimes wonky
  • Undo doesn't work

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7473/as-a-user-i-want-to-be-able-to-add-a-node-between-two-nodes-by

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 11, 2024
Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jul 11, 2024

2 flaky tests on run #5881 ↗︎

0 399 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: 3fcd253da7
Status: Passed Duration: 05:15 💡
Started: Jul 11, 2024 1:43 PM Ended: Jul 11, 2024 1:48 PM
Flakiness  e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #10006 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 1aae65d into master Jul 11, 2024
27 checks passed
@alexgrozav alexgrozav deleted the n8n-7473-as-a-user-i-want-to-be-able-to-add-a-node-between-two-nodes branch July 11, 2024 14:05
@janober
Copy link
Member

janober commented Jul 17, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants