Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gotypes: Handle named types in Component.Resolve #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greatroar
Copy link

@greatroar greatroar commented Mar 17, 2023

Without the Underlying call added in this PR, the modified example's go generate fails with

asm.go:56: component is not primitive
exit status 1
args_test.go:9: running "go": exit status 1

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants