Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF129 Relnote: Navigator.vibrate() removed #34864

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

hamishwillee
Copy link
Collaborator

FF129 stops exposing Navigator.vibrate() because it has been broken for about 4 years, but the presence of the API is still used to feature detect for vibration - https://bugzilla.mozilla.org/show_bug.cgi?id=1653318. This is the release note.

Related docs work can be tracked in #34703

@hamishwillee hamishwillee requested a review from a team as a code owner July 16, 2024 05:20
@hamishwillee hamishwillee requested review from pepelsbey and removed request for a team July 16, 2024 05:20
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed labels Jul 16, 2024
Copy link
Contributor

github-actions bot commented Jul 16, 2024

Preview URLs

External URLs (3)

URL: /en-US/docs/Mozilla/Firefox/Releases/129
Title: Firefox 129 for developers

(comment last updated: 2024-07-26 01:31:12)

Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 22, 2024
@hamishwillee
Copy link
Collaborator Author

@pepelsbey Any chance you could review your release PRs on a weekly basis? Would really help me clear my queue, and reduce pressure on the end of the release cycle if this could be done more regularly.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 on this, thank you!

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d suggest moving this to the “Removals” section to separate it from added features. Also, the “has not worked some years” wording makes Firefox look too sloppy. Maybe we can be a bit more formal here.

@hamishwillee
Copy link
Collaborator Author

I’d suggest moving this to the “Removals” section to separate it from added features. Also, the “has not worked some years” wording makes Firefox look too sloppy. Maybe we can be a bit more formal here.

Thanks @pepelsbey - removals is obviously the right place. I have stripped out the reasons why this was removed as they don't really matter.

@hamishwillee hamishwillee reopened this Jul 26, 2024
@hamishwillee hamishwillee merged commit 0ef4b73 into mdn:main Jul 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants