Add memory efficient polyline decoder #1518
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making a more memory efficient replayer mapbox/mapbox-navigation-android#6636
The first large memory task is to decode a geometry string. This pull requests makes it possible to pass in a string as an InputStream, so that it can come from a file. It will then decode the polyline upon request.
It is true that the geometry string is inside a
DirectionsResponse
so it is already memory inefficient. The reason I'm going ahead with it now is because it simpler for streaming objects to consume downstream.