Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topology): remove usage of k8s plugin from topology & tekton plugins #1869

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

debsmita1
Copy link
Member

@debsmita1 debsmita1 commented Jul 8, 2024

Resolves:
https://issues.redhat.com/browse/RHIDP-3126

  • Replaced dependency@backstage/plugin-kubernetes with @backstage/plugin-kubernetes-react
  • Replicated useKubernetesObjects hook from Backstage upstream to remove dependency on k8s plugin
  • created separated api refs for topology and tekton to avoid duplicate plugin id error

Copy link

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from debsmita1. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@debsmita1 debsmita1 changed the title feat(topology): remove usage of k8s frontend plugin in topology & tekton feat(topology): remove usage of k8s frontend plugin in Topology & Tekton plugins Jul 8, 2024
@invincibleJai
Copy link
Member

/cc @its-mitesh-kumar
/cc @divyanshiGupta

@divyanshiGupta
Copy link
Collaborator

@debsmita1 can you check if the yarn.lock is being updated correctly as to me it seems most of the current changes to it are not required since you are only adding "@backstage/plugin-kubernetes-react" and removing "@backstage/plugin-kubernetes" so only these and related dependencies should get updated. I tried adding this "@backstage/plugin-kubernetes-react" dependency and for me only this "@backstage/plugin-kubernetes-react" and "@backstage/plugin-kubernetes-common" got updated in yarn.lock.

@divyanshiGupta
Copy link
Collaborator

@debsmita1 we need to update tekton and topology plugins README since we are not using "@backstage/plugin-kubernetes" anymore and the README mentions it.

@debsmita1 debsmita1 force-pushed the topology-tekton-td branch 4 times, most recently from 6e917f8 to 61e0371 Compare July 8, 2024 18:03
Copy link
Contributor

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing utils from this shared library @backstage/plugin-kubernetes-react still doesn't make tekton and topology plugins work independently without @backstage/plugin-kubernetes frontend plugin (which registers the KubernetesProxyApi into backstage application).

So this @backstage/plugin-kubernetes is still a pre-requisite for the topology and tekton users.

plugins/tekton/README.md Show resolved Hide resolved
plugins/topology/README.md Show resolved Hide resolved
@debsmita1 debsmita1 changed the title feat(topology): remove usage of k8s frontend plugin in Topology & Tekton plugins feat(topology): remove usage of k8s plugin from topology & tekton plugins Jul 11, 2024
@debsmita1 debsmita1 force-pushed the topology-tekton-td branch 2 times, most recently from 4979434 to ea48ac7 Compare July 11, 2024 19:52
@debsmita1 debsmita1 force-pushed the topology-tekton-td branch 2 times, most recently from d2e5a45 to 0bbe8f9 Compare July 12, 2024 06:36
@karthikjeeyar
Copy link
Contributor

Thanks @debsmita1. Nice work! Verified locally, it works as expected without the dependancy of kubernetes frontend plugin.

tekton_topology_without_k8s_frontend.mov

@debsmita1 debsmita1 force-pushed the topology-tekton-td branch 2 times, most recently from 9e07425 to f56ee9a Compare July 12, 2024 12:21
@jerolimov
Copy link
Member

/cc

@openshift-ci openshift-ci bot requested a review from jerolimov July 15, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants