Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding codingcrew.dino.icu #1235

Merged
merged 11 commits into from
Aug 16, 2024
Merged

Adding codingcrew.dino.icu #1235

merged 11 commits into from
Aug 16, 2024

Conversation

shim-sham
Copy link
Contributor

codingcrew.dino.icu will be used as a website for my coding community / hack club I am setting up in my city in the UK. It outlines what the community will do and how to sign up!

@shim-sham shim-sham requested review from a team as code owners August 12, 2024 13:21
@@ -771,6 +771,7 @@ codeabit:
- ttl: 600
type: CNAME
value: codeabitkw.github.io.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change

dino.icu.yaml Outdated
codingcrew: # by https://github.com/shim-sham
ttl: 600
type: CNAME
value: shim-sham.github.io/coding-crew.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNS records can't have paths in them.

Suggested change
value: shim-sham.github.io/coding-crew.
value: shim-sham.github.io.

@shim-sham shim-sham requested a review from Muirrum August 12, 2024 15:41
@shim-sham shim-sham closed this Aug 13, 2024
@shim-sham shim-sham reopened this Aug 13, 2024
Copy link
Member

@Muirrum Muirrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes to hackclub.com.yaml and you'll be good

@@ -770,7 +770,7 @@ cken:
codeabit:
- ttl: 600
type: CNAME
value: codeabitkw.github.io.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert all changes to this file

@shim-sham shim-sham requested a review from Muirrum August 14, 2024 16:11
Copy link
Member

@Muirrum Muirrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Muirrum Muirrum merged commit 60c34f0 into hackclub:main Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants