Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Column Names in CSV when tracking domains #14

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

sethlaw
Copy link

@sethlaw sethlaw commented Feb 24, 2024

Update utils to ignore the headers of the CSV file in tracking historical domains. Mainly reduce noise in the slack hooks when the tool reports that sni is a domain that no longer exists.

@g0ldencybersec
Copy link
Owner

g0ldencybersec commented Mar 8, 2024

Hey Seth! Just caught up with your PR it has been a busy stint here. One thing with your PR:

  1. It looks like you also committed your go.mod file, which would change the module from "github.com/g0ldencybersec/EasyEASM" to "github.com/sethlaw/EasyEASM"
  2. Because of the change in go.mod, it also changes all the imports on the go files themselves.

If you could please revert the changes to the go.mod file and the import paths, and then I can review and potentially merge your code changes into the original project and shout out your amazing contributions! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants