Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom_fields to the vlan datasource #395

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

a-willem
Copy link

@a-willem a-willem commented May 9, 2023

Netbox has build-in customfields management, while it seems from PR #143 that general custom fields deployment (specifically within resources) seems complicated, adding them to the datasources is a minium enabling Netbox
users to pass their specific data onwards.

Tests seem to be passing :

--> make test
go test netbox/*.go -timeout=120s -parallel=4 -cover
go: downloading github.com/stretchr/testify v1.8.2
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
ok command-line-arguments 0.365s coverage: 2.9% of statements

@a-willem a-willem changed the title Aw-vlan_custom_fields Add custom_fields to the vlan datasource May 9, 2023
@fbreckle
Copy link
Collaborator

Hi! Thanks for your MR!
Can you please add a test that actually uses the new attribute?

@a-willem
Copy link
Author

Hi ! Sorry for taking so long answering your request.

While I might be able to identify the right code and duplicate it to grab custom fields, I'm evidently not Go-fluent enough to write a unit-test requiring to setup the whole thing. If anyone'd like to help over here and/or take over the PR, feel free !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants