Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(js_semantic): use range start to identify the declaration in read/write #3404

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Conaclos
Copy link
Member

Summary

Previous PR switched from range to range start to identify a declaration.
This PR spread the change even further by using range start to identify the declaration in a read, write and export.

Test Plan

CI must pass.

@Conaclos Conaclos changed the title refactor(js_semantic): use range start to identify the declaration in refreences refactor(js_semantic): use range start to identify the declaration in read/write Jul 10, 2024
@github-actions github-actions bot added A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages labels Jul 10, 2024
@Conaclos Conaclos force-pushed the conaclos/semantic-model-minor-change branch from 30293be to 284a208 Compare July 10, 2024 16:14
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48293 48293 0
Passed 47096 47096 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6541 6541 0
Passed 2198 2198 0
Failed 4343 4343 0
Panics 0 0 0
Coverage 33.60% 33.60% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18258 18258 0
Passed 13994 13994 0
Failed 4264 4264 0
Panics 0 0 0
Coverage 76.65% 76.65% 0.00%

@Conaclos Conaclos merged commit 08f0c8f into main Jul 10, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/semantic-model-minor-change branch July 10, 2024 16:26
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant