Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TNO-2843 Request subscription #2022

Merged
merged 6 commits into from
Jul 23, 2024
Merged

TNO-2843 Request subscription #2022

merged 6 commits into from
Jul 23, 2024

Conversation

kkwangsir
Copy link
Contributor

@kkwangsir kkwangsir commented Jul 11, 2024 •
edited
Loading

Summary:

  1. add UI to send request of subscription. If user is already in the subscribers list pop up unsubscribe confirmation modal or pop up subscribe as usual.
  2. change store and update api in front end and tno-core.
  3. build endpoints in backend to receive subscribe/unsubscribe request and send email.

I also need tno-core new version

image

1
2
image

@kkwangsir kkwangsir force-pushed the request-subscription branch 3 times, most recently from a6c0f15 to 138aa06 Compare July 18, 2024 18:19
@kkwangsir kkwangsir changed the title TNO-2843 Request subscription (draft) TNO-2843 Request subscription Jul 18, 2024
Fosol
Fosol requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've published tno-core:0.1.108

@Fosol Fosol added enhancement New feature or request subscriber PR contains changes towards the subscriber application, tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues. labels Jul 19, 2024
@Fosol
Copy link
Collaborator

Fosol commented Jul 19, 2024

You will need a new tno-core package because we've merged Jonny's PR first.

Fosol
Fosol requested changes Jul 22, 2024
View reviewed changes
app/subscriber/package.json Outdated
@@ -42,7 +42,7 @@
"sheetjs": "file:packages/xlsx-0.20.1.tgz",
"styled-components": "6.1.11",
"stylis": "4.3.2",
"tno-core": "0.1.105"
"tno-core": "0.1.108"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know presently we're at 0.1.110. You need to rebase your PR and publish a new tno-core package version. Make sure you publish with the latest code changes within the dev branch.

@Fosol Fosol merged commit e8cf1b1 into bcgov:dev Jul 23, 2024
2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fosol Fosol Fosol approved these changes

Assignees

@kkwangsir kkwangsir

Labels
enhancement New feature or request subscriber PR contains changes towards the subscriber application, tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkwangsir @Fosol