Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix SnsAction typo for aws-cdk-lib aws_cloudwatch Alarm addAlarmAction #30867

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

pyepye
Copy link
Contributor

@pyepye pyepye commented Jul 16, 2024

Issue # (if applicable)

N/A

Reason for this change

Fixing a typo

Description of changes

Fixing a typo in the docs under aws-cdk-lib aws_cloudwatch Alarm addAlarmAction

Description of how you validated changes

Spell checker

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 16, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 16, 2024 14:40
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 16, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pyepye pyepye changed the title Fix SnsAction typo for aws-cdk-lib aws_cloudwatch Alarm addAlarmAction docs: Fix SnsAction typo for aws-cdk-lib aws_cloudwatch Alarm addAlarmAction Jul 16, 2024
@pyepye pyepye changed the title docs: Fix SnsAction typo for aws-cdk-lib aws_cloudwatch Alarm addAlarmAction docs: fix SnsAction typo for aws-cdk-lib aws_cloudwatch Alarm addAlarmAction Jul 16, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 16, 2024 15:42

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 16, 2024
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a t in action!
Thanks @pyepye

Copy link
Contributor

mergify bot commented Jul 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 16, 2024
Copy link
Contributor

mergify bot commented Jul 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cd2a54c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 40a8e61 into aws:main Jul 17, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Jul 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants