Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader #2657

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cgivre
Copy link
Contributor

@cgivre cgivre commented Sep 21, 2022

DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader

Description

Converts the Druid storage plugin to use the V2 JSON reader. Also, updates the docker to test this plugin with the latest version of Druid.

Documentation

No user facing changes.

Testing

Ran existing unit tests.

@cgivre
Copy link
Contributor Author

cgivre commented Feb 12, 2023

@Z0ltrix Would you mind reviewing this? The unit tests pass, but I'm not 100% certain this is handling large data sets correctly.

@cgivre cgivre requested a review from jnturton July 15, 2024 01:35
@cgivre
Copy link
Contributor Author

cgivre commented Jul 15, 2024

@jnturton
Could you do a review of this. I realized that this has been languishing and we might as well merge it if it can be.
The one area which I'm a little hesitant about is the ScanBatchCreator. Basically, since I didn't write this storage plugin and it was a bit more complicated than some of the ones I've written, I'd like another set of eyes on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-cleanup json JSON Format refactoring PR related to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant