update vlc,ffmpeg PREFERRED_PROVIDER #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agherzan
reviewed
Jun 17, 2024
9ba1f74
to
ad757b3
Compare
ad757b3
to
9573256
Compare
|
@kraj Any status |
kraj
approved these changes
Aug 20, 2024
|
@kraj what do you mean by docs? Git log or readthedocs? If the latter, I think the commit already adds information about that. |
the same .md file in the PR, which mentions about preferred providers. |
|
@kraj Could you have an in-line text proposal? Just to make sure we are aligned on what you propose here. |
Yeah will send separately merge this one |
Switch to defaulting to OE core ffmpeg & meta-openembedded vlc. Upgrades to newer rpi-distro VLC version in an OE environment have proven to be tedious due to all the PI foundation patches. Some patches aren't fully pushed into github and require updates to build. Maintaining patches have also proven to be unstable. Defualt to stable builds of both so that. Peoples builds aren't broken. If rpi-distro rpi-distro version of ffmpeg & vlc wanted users may switch by setting PREFFERED_PROVIDER. Signed-off-by: Vincent Davis Jr <[email protected]>
Signed-off-by: Vincent Davis Jr <[email protected]>
auto-merge was automatically disabled
August 29, 2024 01:17
Head branch was pushed to by a user without write access
9573256
to
faea953
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Switch to defaulting to OE core ffmpeg &
meta-openembedded vlc.
- Reason
Upgrades to newer rpi-distro VLC version
in an OE environment have proven to be
tedious due to all the PI foundation patches.
Some patches aren't fully pushed into github
and require updates to build.
Maintaining patches have also proven to be unstable.
Default to stable builds of both so that peoples
builds aren't broken.
If rpi-distro version of ffmpeg & vlc wanted
users may switch by setting PREFFERED_PROVIDER.
- How I did it
@kraj @agherzan .
What do you guys think?