Kirkstone rpi-eeprom #1238
Kirkstone rpi-eeprom #1238
Conversation
To better support rpi-eeprom without depending on userland it was decided to build nvmem-rmem support into the kernel for Raspberry Pi 4 machines. Signed-off-by: Allan Xavier <[email protected]>
This recipe will allow yocto images to support configuring and updating the bootloader on Raspberry Pi 4 boards. So far this recipe just includes the commands and firmware with no automation for updates. Note that this depends on nvmem-rmem support either built into the kernel or as a module. If that is not part of the kernel the scripts will error out suggesting that the vcgencmd command from the userland package is missing. Whilst using vcgencmd from the userland package does work, it would lead to a conflict with the mesa backend for graphics, so using the kernel interface is recommended. Co-authored-by: Maciej Pijanowski <[email protected]> Signed-off-by: Allan Xavier <[email protected]>
| @@ -0,0 +1 @@ | |||
| RPROVIDES:${PN} += " xxd" | |||
There was a problem hiding this comment.
I think instead of using vim to provide xxd, we can use xxd from busybox?
busybox_%.bbappend:
FILESEXTRAPATHS:append := ":${THISDIR}/${PN}"
SRC_URI += "file:https://enable-xxd.cfg"
RPROVIDES:${PN} += " xxd"
- Add
enable-xxd.cfg
CONFIG_XXD=y
CC/ @agherzan for feedback
There was a problem hiding this comment.
Using vim is what the master branch does, so the RPROVIDES="xxd" change was backported from that. I wasn't aware busybox provided an implementation of xxd either.
There was a problem hiding this comment.
Sure, but this is just not right in the BSP without any additional guards, explanations etc.
There was a problem hiding this comment.
we already use update-alternatives to provide appropriate xxd. If we do not include vim-xxd in image then it will nicely fallback to busybox to provide it. We perhaps do not require anything to do here.
There was a problem hiding this comment.
I don't know what to tell you other than if you remove that it doesn't build.
There was a problem hiding this comment.
I confirmed as well - Without vim or busbybox explicitly providing xxd, rpi-eeprom doesn't build on kirkstone
There was a problem hiding this comment.
How does this work in the source of the backport? We really need a way to first understand the problem. All we have is a commit that says Add RPROVIDES="xxd" to vim so that rpi-eeprom can be built on kirkstone branch. We need an explanation (not to mention the commit message format (https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html),
This is not a mistake. It is required for it to work and this is a backport from master. |
| @@ -0,0 +1 @@ | |||
| RPROVIDES:${PN} += " xxd" | |||
There was a problem hiding this comment.
Sure, but this is just not right in the BSP without any additional guards, explanations etc.
This is a simple backport of the changes from #1131 to the kirkstone branch.