-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Raspberry Pi Camera Module v3 to Kirkstone (compatibility patch) #1197
base: kirkstone
Are you sure you want to change the base?
Conversation
Could you add the rationale and context in the description? |
Reopened as I've closed it by mistake. |
I hope this is clear enough. |
@Jessseee made it here from the Balena thread? Any way we can help get this over the line, we'd like to use camera v3 on Balena OS on Pi4 |
I'm generally happy with this, but we will need to first land it via a review in master. It looks good to me otherwise. |
dynamic-layers/imx708-layer/recipes-kernel/linux/linux-raspberrypi-dev.bbappend
Outdated
Show resolved
Hide resolved
Is is possible this is already done via #1158? |
That's what I hoped and thought, but this seems to include more things. @Jessseee can you explain the backport so I understand where we are with this? I suspect it is something along the "we don't have the right dtb in the kirkstone kernel versions" but I would expect a bbappend to our recipes not an external layer. |
Sorry, I completely missed that! |
I am quite new to working with yocto, so I am not quite sure what the best approach is. However, my idea was that because the dts file is completely missing from Kernel 5.10 it has to be externally added. |
That makes sense @Jessseee. I think the best would be to introduce it in the kernel recipes we have in the layer - linux-raspberrypi ones. |
@Jessseee I think you can just make your bbappend for the dts I am quite new to yocto too, but I patched a dtoverlay in a similar way in BalenaOS once. |
@mhazley The problem is that the devicetree files should only be added to |
@agherzan Is there any update on this approved? Also thank you for doing the work and adding it to the meta-raspberrypi layer! |
@Jessseee This looks good. One last request: can you please squash "imx708: Add compatibility layer " into "recipe-bsp: Add support for Raspberry Pi Camera Module v3". They make sense as one commit. Otherwise, I think we are good to go. |
2e22b78
to
b47af61
Compare
I squashed the commits and updated the branch. |
@@ -24,6 +24,8 @@ SRC_URI = " \ | |||
git:https://git.yoctoproject.org/yocto-kernel-cache;type=kmeta;name=meta;branch=${LINUX_RPI_KMETA_BRANCH};destsuffix=${KMETA} \ | |||
file:https://powersave.cfg \ | |||
file:https://android-drivers.cfg \ | |||
file:https://imx708-overlay.dts;subdir=git/arch/${ARCH}/boot/dts/overlays \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach. @kraj does this have any downsides? I don't see any - maybe when using devtool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be better to have it as a patch, if it gets added in one of future kernels then we wont be overwriting it without knowing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a fair point. @Jessseee do you reckon you can update this with a patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agherzan, I changed the addition of the imx708 dt-overlay to a patch.
Signed-off-by: Jesse Visser <[email protected]>
Signed-off-by: Jesse Visser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for chasing this up.
recipes-kernel/linux/files/0003-recipe-bsp-Add-imx708-dt-overlay-files.patch
Show resolved
Hide resolved
@@ -0,0 +1,196 @@ | |||
From a66bb44e8c32170d2de5ea29ae16b30d9a5e2b06 Mon Sep 17 00:00:00 2001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have been misunderstood. I was proposing to have this as a commit over the kernel source. Ideally, a formatted patch directly from rpi Linux kernel upstream. Does that make sense? Also, mind Upstream-status footer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, I expect:
- Cherry-pick Add support for Raspberry Pi Camera Module v3 #1158
- Add a commit that adds a kernel patch to include the respective dtb (ideally as clean/backported patch from upstream)
The imx708 devicetree layer is required for use of the Raspberry Pi Camera Module v3. This was implemented in #1158 on master. However, the dts file is not included with Kernel 5.10. Therefore, to port these changes to Kirkstone, I added a dynamic layer to install the imx708 devicetree overlay when building for Linux kernel 5.10. Also see #1172 for more context.