Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix request #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix request #37

wants to merge 1 commit into from

Conversation

jiyongjeong
Copy link

  1. text input error %%s to %s%s, geometry shader output is strange.
  2. texname variable is applied wrong type index.
    example[ declaration : texture2dms tex; , implementation :
    sampler2d(tex, ..) ]

bugfix request
3520fe9 
1) text input error %%s to %s%s, geometry shader output is strange.
2) texname variable is applied wrong type index.
example[ declaration : texture2dms tex; , implementation :
sampler2d(tex, ..) ]
@jiyongjeong
Copy link
Author

envMap_skyGS.zip
i'm trying to cso to glsl. but geometry shader was error sometimes.
i found error and edit error code.
first %%s to %s%s
second texture type was wrong implemented by wrong sampler type
please check this issue. thanks you.

@aet aet mentioned this pull request Dec 27, 2018
Merged
@aet
Copy link
Contributor

aet commented Dec 27, 2018

Thanks! I've applied the obvious formatting fix manually into the latest batch of changes from upstream, due to indentation changes etc

The texture/sampler logic fix currently under review/inspection, to be continued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiyongjeong @aet