Rework entity visibility

[Efnilite]

Description

Adds support for the hideEntity, showEntity and canSee(Entity) and removes the player-only equivalents, which are functionally equivalent. Also updates the Hidden Players syntax to match the current style guide and to improve the naming of the variable required for reveal hidden players of {_p}.

I wasn't sure on how to do the test for the can see condition, as this will have to be done with JUnit to mock the player, but I couldn't get it to work properly with canSee. pls help :)

---

Target Minecraft Versions: 1.19+ (Skript 2.10)
Requirements: none
Related Issues: #6795

[cheeezburga]

Can this just be put into the already existing CanSee condition and PlayerVisibility effect instead of making brand new ones?

[Efnilite]

Can this just be put into the already existing CanSee condition and PlayerVisibility effect instead of making brand new ones?

Not sure about that, since the entity one has only been around since Spigot 1.19, but idk

[cheeezburga]

Can this just be put into the already existing CanSee condition and PlayerVisibility effect instead of making brand new ones?

Not sure about that, since the entity one has only been around since Spigot 1.19, but idk

You should just be able to change which kind of type is accepted in the pattern based on whether or not a certain method exists, if that makes sense.

[sovdeeth]

You can just change it entirely since 2.10 will be 1.19+

[ShaneBeee]

Just a few little things

[cheeezburga]

Just some small things I saw - I think some of them are just preference so up to you. Stuff like the star imports tho are pretty up there.

[sovdeeth]

re: mock tests, you would need to provide your own logic implementation for canSee, since mocked objects have no inherent logic. I'm not sure if a junit test here is worth it.

[sovdeeth]

what's the status of the junit tests?

[Efnilite]

what's the status of the junit tests?

i think the EffEntityVisibility test is fine, but not really sure how to improve the one for CondCanSee. maybe adding an entity to a collection when it's hidden and then canSee checking that list? suggestions welcome :)

[sovdeeth]

what's the status of the junit tests?

i think the EffEntityVisibility test is fine, but not really sure how to improve the one for CondCanSee. maybe adding an entity to a collection when it's hidden and then canSee checking that list? suggestions welcome :)

That'd work! As long as there's some basic logic implementation.