Improve variable names in EffChange #6779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
requested changes
Jun 10, 2024
Comment on lines
+273
to
277
| if (deltaReturnTypeClassInfo.getC() != Object.class && deltaReturnTypeClassInfo.getSerializer() == null && deltaReturnTypeClassInfo.getSerializeAs() == null && !SkriptConfig.disableObjectCannotBeSavedWarnings.value()) { | ||
| if (getParser().isActive() && !getParser().getCurrentScript().suppressesWarning(ScriptWarning.VARIABLE_SAVE)) { | ||
| Skript.warning(ci.getName().withIndefiniteArticle() + " cannot be saved, i.e. the contents of the variable " + changed + " will be lost when the server stops."); | ||
| Skript.warning(deltaReturnTypeClassInfo.getName().withIndefiniteArticle() + " cannot be saved, i.e. the contents of the variable " + expressionToChange + " will be lost when the server stops."); | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe it's just github UI messing up but it looks like we have two ifs nested in here and neither of them have an else, maybe they could be combined or tidied up somehow?
| final Expression<?> changer = this.changer; | ||
| switch (mode) { | ||
| public String toString(final @Nullable Event event, final boolean debug) { | ||
| assert deltaValuesExpression != null; |
There was a problem hiding this comment.
Won't this cause problems in test mode if it ever gets stringified? For DELETE and RESET it is null, right? (If not the field probably shouldn't be @Nullable so we won't need this assertion)
sovdeeth
approved these changes
Jun 28, 2024
UnderscoreTud
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some more descriptive variable names to EffChange. It also swaps complicated ternaries for if/else instead.
Target Minecraft Versions: any
Requirements: none
Related Issues: none