Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pad locus tag number with zeros #85

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

bartns
Copy link

@bartns bartns commented Mar 14, 2024

Thanks for this tool it can be very convenient! I had some augustus like gff3 file that needed be converted. But I personally like to see locus tags numbering padded with zeros. So I added it and made it an option to the script. It works only for the newly created locus tags numbering.

It takes the total amount of features for the padding amount.
For examples, when there are 9999 features it will increment the locus tags as 0001,0002,etc to 9999.

It worked in my case and didn't seem to fail any of the tests.
Feel free to do whatever you like with it.

Kind regards, Bart.

@Juke34
Copy link
Collaborator

Juke34 commented Mar 14, 2024

May I ask you if you use EMBLmyGFF3 for conversion only or for submitting data to ENA?
Just for your information, in the case of submission the locus_tag will be anyway overwritten.

@bartns
Copy link
Author

bartns commented Mar 14, 2024

Yes, for submission in this particular case and I did not realize this... Thanks for heads up. But how does that work? What will ENA do with it? The numbering method is quite crucial in case of locus tags. If I use for example a tool like bakta it will create locus tags with increments of 5.

I think it would be nice to have the most closely resembled version of the submitted locus tag before submission.

@Juke34
Copy link
Collaborator

Juke34 commented Mar 14, 2024

Sorry my mistake they just add a prefix to the locus tag, so it should be fine.
This prefix may be choosen when registering the sample, otherwise they will give one by default.

@Juke34
Copy link
Collaborator

Juke34 commented Mar 14, 2024

Thank you for your PR

@Juke34 Juke34 merged commit 2e1d923 into NBISweden:master Mar 14, 2024
3 checks passed
@bartns
Copy link
Author

bartns commented Mar 14, 2024

No problem. Happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants