Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was trying to display a GLMakie window in fullscreen, as described in discourse. The problem was that the fullscreen keyword in the
GLMakie.activate!()
function appeard to have no effect. As suggested there, the keyword wasn't actually used in the source code.I then read the GFLW documentation, to see how would one make a fullscreen window. It appears that a call to the function
glfwSetWindowMonitor
does the job, so I tried to find where it is called in the GLMakie source code. To my surprise, it is called with a wrong signature! I then attempted to fix it, and with this new version, the following code produces the result that I desire: a fullscreen image.In the master branch, this will error do to the incorrect call to
GLFW.SetWindowMonitor
.I'm not really familiar with the repository, so I don't know if this change might have effects elsewhere. If this is the right fix for the fullscreen problem, then the keyword could be removed, as it is not being used, and we should also update the docs.