Update dependencies. #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses some critical audit problems. Also the upgrade to XLSX allows it to work in React. There are a few dev dependencies that fail audit, namely istanbul, which is a deprecated package. Perhaps in a future PR this can be replaced with nyc (https://www.npmjs.com/package/nyc)
|
This fails CI because Since node 6 is not longer being maintained, would it be appropriate to keep the node version at least what is being maintained (https://nodejs.org/en/about/releases/) -- so allow node 8 until Jan 2020, then bump to node 10? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the work on this library!
This PR addresses some critical audit problems. Also the upgrade to XLSX allows it to work in React (my main motivation for doing this :)).
There are a few dev dependencies that fail audit, namely istanbul, which is a deprecated package. Perhaps in a future PR this can be replaced with nyc (https://www.npmjs.com/package/nyc)...