Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang/llvm 19 compilation issue in iterator.h (issue #8313) #8330

Merged

Conversation

tylermorganwall
Copy link
Contributor

Patch to fix compilation issue in clang//llvm 19 (#8313)

@sloriot
Copy link
Member

sloriot commented Jul 8, 2024

Successfully tested in CGAL-6.0-Ic-282

@lrineau lrineau added this to the 6.0 milestone Jul 11, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jul 11, 2024
@lrineau lrineau self-assigned this Jul 11, 2024
Confirmed fix to compilation issue in clang//llvm 19 (CGAL#8313)
@lrineau lrineau force-pushed the tylermorganwall-patch-issue-8313 branch from 3daf9db to 2b0c9fb Compare July 16, 2024 13:26
@github-actions github-actions bot removed the Tested label Jul 16, 2024
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@lrineau lrineau changed the base branch from master to 5.6.x-branch July 16, 2024 13:26
@lrineau lrineau added the Tested label Jul 16, 2024
@github-actions github-actions bot removed the Tested label Jul 17, 2024
@sloriot sloriot modified the milestones: 6.0, 5.6.2 Jul 23, 2024
@sloriot sloriot merged commit 1332ce3 into CGAL:5.6.x-branch Jul 23, 2024
7 of 8 checks passed
@tylermorganwall tylermorganwall deleted the tylermorganwall-patch-issue-8313 branch July 23, 2024 15:19
@sloriot sloriot removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jul 23, 2024
@mering
Copy link

mering commented Oct 8, 2024

@sloriot @lrineau would it be possible to cut a new release containing this PR now that LLVM 19 is released?

@lrineau
Copy link
Member

lrineau commented Oct 8, 2024

Hi @mering, I have not yet officially announced CGAL-6.0 by email, because it has several last-minute bugs, that were detected by the CI tests of downstream package managers. I plan to publish a CGAL-6.0.1 pretty soon.

@mering
Copy link

mering commented Oct 9, 2024

Hi @mering, I have not yet officially announced CGAL-6.0 by email, because it has several last-minute bugs, that were detected by the CI tests of downstream package managers. I plan to publish a CGAL-6.0.1 pretty soon.

Do you plan any further releases on the 5.6 branch? There are quite some commits since the last release there.

@lrineau
Copy link
Member

lrineau commented Oct 9, 2024

Hi @mering, I have not yet officially announced CGAL-6.0 by email, because it has several last-minute bugs, that were detected by the CI tests of downstream package managers. I plan to publish a CGAL-6.0.1 pretty soon.

Do you plan any further releases on the 5.6 branch? There are quite some commits since the last release there.

Yes, that is planned to. I plan to release one bug-fix for 5.5.x and one for 5.6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants