Added sysconfig support for non-container images #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeoutside
changed the title
|
I think this is fine, but should it always happen? We don't necessarily want to change the default behavior. |
|
@otakup0pe I did add a check to see if there was a sysconfig directory. I believe centos/rhel docker container images do not have that set up and this role is expecting supervisord to be configured. If you look at the job log, it'll skip the non-container tasks. https://travis-ci.org/ANXS/postgresql/jobs/198116075#L1295-L1300 |
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this role utilizes containers and systemd was set up by default. Wanted to add support for sysconfig for non-container images.