Give the possibility to pass extensions options to the config template #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like test failing due to missing defaults ? |
nremond
force-pushed
the
extension_options
branch
from
4235fc5
to
97f587e
Compare
|
@otakup0pe yes, sorry. Just fixed that. |
otakup0pe
reviewed
Sep 28, 2016
| @@ -683,3 +683,6 @@ postgresql_pgdg_dists: | |||
| postgresql_version_terse: "{{ postgresql_version | replace('.', '') }}" | |||
| postgresql_yum_repository_base_url: "http:https://yum.postgresql.org" | |||
| postgresql_yum_repository_url: "{{ postgresql_yum_repository_base_url }}/{{ postgresql_version }}/{{ ansible_os_family | lower }}/rhel-{{ ansible_distribution_major_version }}-{{ ansible_architecture }}/pgdg-{{ postgresql_pgdg_dists[ansible_distribution] }}{{ postgresql_version_terse }}-{{ postgresql_version }}-2.noarch.rpm" | |||
|
|
|||
| # List of options from loaded extensions (optional) | |||
| postgresql_extensions_options: [] | |||
There was a problem hiding this comment.
What is an example of this format? It looks like a free-form way of injecting config entries?
There was a problem hiding this comment.
Right. My use-case is the following, I am using the pg_stat_statements extension and I would like to be able to add pg_stat_statements.track = all in the config.
Does this sound good to you or would you prefer passing something like { key: 'pg_stat_statements.track', value: 'all' } ?
nremond
force-pushed
the
extension_options
branch
from
97f587e
to
deb8066
Compare
|
I have updated my PR with a dictionary and an example of how to use it in the README. |
nremond
force-pushed
the
extension_options
branch
from
deb8066
to
291d5d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.