Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider reworking ZydisShortString #263

Open
athre0z opened this issue Nov 6, 2021 · 0 comments
Open

Consider reworking ZydisShortString #263

athre0z opened this issue Nov 6, 2021 · 0 comments
Labels
A-formatter Area: Formatter C-enhancement Category: Enhancement of existing features P-low Priority: Low

Comments

@athre0z
Copy link
Member

athre0z commented Nov 6, 2021 •
edited
Loading

Because #259 had to remove the struct packing on aarch64 darwin, it might be worth considering to do what @flobernd suggested in a response to the PR:

Maybe as an improvement, we could prepend the length to the actual strings (this should be easily possible as we generate the strings anyways) and remove the 'length' field from the struct. In this case a struct would not even be necessary, but probably still desired as a hint.
@athre0z athre0z added C-enhancement Category: Enhancement of existing features A-formatter Area: Formatter P-low Priority: Low labels Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-formatter Area: Formatter C-enhancement Category: Enhancement of existing features P-low Priority: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@athre0z