Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strips comments inside types #6

Open
nickretallack opened this issue Apr 5, 2020 · 3 comments
Open

Strips comments inside types #6

nickretallack opened this issue Apr 5, 2020 · 3 comments
Labels
comments Comments are removed or printed in a wrong place

Comments

@nickretallack
Copy link

This issue also occurs if I just use babel-plugin-flow-to-typescript directly so I filed the issue there. Creating an issue here as well so you're aware of it.

I really appreciate your work on these conversion tools. I just ran it on a large code base and audited all the changes and now I'm filing issues about any oddities I found.

@zxbodya
Copy link
Owner

zxbodya commented Apr 5, 2020

will look into it, however not sure it would be easy to fix… - it is a bit tricky to preserve comments in babel transform

also btw, original babel-plugin-flow-to-typescript is not updated for a while - in flowts I am using my fork of it - https://github.com/zxbodya/babel-plugin-flow-to-typescript

@nickretallack
Copy link
Author

There's no issues tab on your fork of the babel plugin. Should I file the issues here instead then?

@zxbodya
Copy link
Owner

zxbodya commented Apr 5, 2020

There's no issues tab on your fork of the babel plugin. Should I file the issues here instead then?

weird, it happened to be disabled by default - enabled it

@zxbodya zxbodya added the comments Comments are removed or printed in a wrong place label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comments Comments are removed or printed in a wrong place
Projects
None yet
Development

No branches or pull requests

2 participants