Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something went wrong trying to analyze the ReScript project with compiler v11-rc.4 #466

Closed
mununki opened this issue Oct 11, 2023 · 10 comments

Comments

@mununki
Copy link

mununki commented Oct 11, 2023

I've been using the cli command to remove unused field using ci. I encounter that the cli command failed to run with the compiler v11-rc.4 today.

$ npx rescript-relay-cli remove-unused-fields --ci --verbose
✖ Something went wrong trying to analyze the ReScript project.

I'm using rescript-relay@^v2.0.0

@zth
Copy link
Owner

zth commented Oct 11, 2023

I assume you've tried cleaning etc?

@mununki
Copy link
Author

mununki commented Oct 11, 2023

Yes, I deleted the generated directory /src/__generated__ for my case, then re-generated the project with relay watch command. But still same.

@zth
Copy link
Owner

zth commented Oct 11, 2023

I can't reproduce this. Could you go into the CLI JS code and log what the actual error is? If you search for "Something went wrong trying to analyze the ReScript project." is should be easy to find a place where you can log.

@mununki
Copy link
Author

mununki commented Oct 11, 2023

Oh, I didn't know that the cli utilize reanalyze before.

const p = cp.spawn("npx", ["--yes", "reanalyze", "-dce"]);

I guess reanalyze couldn't find the rescript.json. I'll close this issue and open it in upstream.

@zth
Copy link
Owner

zth commented Oct 11, 2023

Ahhh yeah, this is going to be a problem until @rescript/tools ship and we can depend on that. The CLI currently uses an old unupdated version of reanalyze. The tools package ships the updated one, which eventually will cover the rescript.json case as well.

@mununki mununki closed this as completed Oct 11, 2023
@DZakh
Copy link
Contributor

DZakh commented Nov 8, 2023

I've come across the issue. Why is it completed?

@zth
Copy link
Owner

zth commented Nov 8, 2023

This should be fixed in the latest release (went out today).

@zth
Copy link
Owner

zth commented Nov 8, 2023

@DZakh please confirm.

@DZakh
Copy link
Contributor

DZakh commented Nov 9, 2023

I can't update rescript-relay 🥲
#476

@DZakh
Copy link
Contributor

DZakh commented Nov 9, 2023

It works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants