Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a python_requires to setup.py #94

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Add a python_requires to setup.py #94

merged 1 commit into from
Apr 6, 2020

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Apr 6, 2020

Fixes #93.

Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

I think I prefer the multi-line spelling I copied from somewhere else. It seems like it might be easier to maintain?

    python_requires=', '.join([
        '>=2.7',
        '!=3.0.*',
        '!=3.1.*',
        '!=3.2.*',
        '!=3.3.*',
        '!=3.4.*',
    ]),

@ale-rt
Copy link
Member

ale-rt commented Apr 6, 2020

Works for me.

I think I prefer the multi-line spelling I copied from somewhere else. It seems like it might be easier to maintain?

    python_requires=', '.join([
        '>=2.7',
        '!=3.0.*',
        '!=3.1.*',
        '!=3.2.*',
        '!=3.3.*',
        '!=3.4.*',
    ]),

With a formatter like black this will go anyway in one line unless one forces this line to be unformatted (with the special '# fmt: off' comment).
I would go with one line.
Hopefully this line will be soon: python_requires='>3.6' ;)
Just my 2c.

@mgedmin
Copy link
Member Author

mgedmin commented Apr 6, 2020

@jamadden I like the multi-line spelling, and I agree that it's easier to maintain -- if you do that manually.

I don't maintain Python versions manually; I have check-python-versions for that. It writes python_require expressions for me. I have plans to teach it to write those multi-line expressions you prefer, but I haven't done that yet.

@mgedmin mgedmin merged commit a80dc2f into master Apr 6, 2020
@mgedmin mgedmin deleted the add-python-requires branch April 6, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing python_requires
3 participants