Set IDecimal attributes min, max and default as Decimal typ…
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadden
approved these changes
Mar 6, 2020
CHANGES.rst
Outdated
| @@ -2,8 +2,12 @@ | |||
| Changes | |||
| ========= | |||
|
|
|||
| 5.0 (unreleased) | |||
| ================ | |||
| 4.9.4 (unreleased) | |||
There was a problem hiding this comment.
I think the NFC change was considered potentially breaking, so a major version bump to 5.0.0 was appropriate.
CHANGES.rst
Outdated
| 4.9.4 (unreleased) | ||
| ================== | ||
|
|
||
| - Set `IDecimal` attributes `min`, `max` and `default` as `Decimal` type |
There was a problem hiding this comment.
Double backticks ("``") for literals, please. Otherwise with a single backtick ("`") you're using the default role, which tends to render in italics unless otherwise configured (as happens when the changelog is rendered on PyPI).
…e instead of `Number`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
IDecimalattributesmin,maxanddefaultasDecimaltype instead ofNumber.fixes #88