Include a field's interface in equality and hashing. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
approved these changes
Aug 31, 2018
|
Thanks! |
jamadden
added a commit
that referenced
this pull request
Sep 1, 2018
Fixes #18 Some other vocabulary fixes while I was in there: - Make TreeVocubalary.fromDict only actually assign titles when a title is given. This makes it consistent with SimpleVocubalary.fromItems(). - Give equality and hash methods to SimpleTerm and SimpleVocubalary. This was a confusing stumbling block in the implementation of #51.
jamadden
added a commit
that referenced
this pull request
Sep 1, 2018
Fixes #18 Some other vocabulary fixes while I was in there: - Make TreeVocubalary.fromDict only actually assign titles when a title is given. This makes it consistent with SimpleVocubalary.fromItems(). - Give equality and hash methods to SimpleTerm and SimpleVocubalary. This was a confusing stumbling block in the implementation of #51.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
There will be test conflicts with #50. Once either of them is merged I will fix the test conflicts and expand the usage of the EqualityTestsMixin to cover the rest of the fields in the remaining PR.