Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

‘Create a classroom’ fails without a visible error #325

Closed
eatyourgreens opened this issue May 14, 2022 · 3 comments · Fixed by #331
Closed

‘Create a classroom’ fails without a visible error #325

eatyourgreens opened this issue May 14, 2022 · 3 comments · Fixed by #331
Assignees
@eatyourgreens
Labels
bug

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented May 14, 2022 •
edited
Loading

Pressing ‘Create a classroom’ causes the page to hang.

From the dev console: the store is undefined in the classroom form. The fix might be the same as the fix for tutorials and field guides in zooniverse/Panoptes-Front-End#6133

Probably caused by this PR.
#284
@eatyourgreens eatyourgreens self-assigned this May 14, 2022
@eatyourgreens eatyourgreens mentioned this issue May 14, 2022
Closed
@eatyourgreens
Copy link
Contributor Author

This happens wherever store context is accessed by connect() inside a Grommet Layer. The underlying cause is this React issue.
facebook/react#13336

@eatyourgreens
Copy link
Contributor Author

We fixed this same issue in PFE by wrapping popups in context providers:
zooniverse/Panoptes-Front-End#4287

@eatyourgreens
Copy link
Contributor Author

Another solution would be to use Layer inside connected components. The export modal and camera view components do this.

@eatyourgreens eatyourgreens mentioned this issue May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eatyourgreens eatyourgreens

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@eatyourgreens