Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffering / Stream support #353

Open
stavros-zavrakas opened this issue Jan 25, 2018 · 10 comments
Open

Buffering / Stream support #353

stavros-zavrakas opened this issue Jan 25, 2018 · 10 comments

Comments

@stavros-zavrakas
Copy link

Is there a plan to support buffering / stream support?

I've tried to use the sound from the network but I wasn't successful. There is this module (https://github.com/tlenclos/react-native-audio-streaming) that is not really maintained anymore but it is able to stream from the network. Do you think that this can be supported at some point in react-native-sound?

@mateioprea
Copy link

mateioprea commented Feb 10, 2018

@stavros-zavrakas use react-native-video for streaming for now. works with audio streams too :)

@johncblandii
Copy link

That's a pretty sucky response to what is clearly a needed feature. Why wontfix vs, at a minimum, putting it on the backlog?

@trepidity
Copy link
Collaborator

OK, sorry. I didn't explain because I felt that the issue had been discussed in other topics.

The deal is that this library doesn't use a library that supports streaming #292. We would have to rewrite and use the correct library. I don't know the amount of work required, but I bet it's not trivial. If someone wants to tackle that, great, but I'm not aware of anyone so far.

If someone wants to submit a PR with the correct AVPLayer, I'm all game for that.

@trepidity trepidity reopened this Feb 15, 2018
@ohtangza
Copy link

ohtangza commented Feb 16, 2018

@johncblandii @trepidity I agree that supporting streaming is not easy because it requires lots of work in native side (almost equivalent to re-writing this library). Since this library is used by production apps including our team's, I guess we need to focus on stabilization of the existing functionality. Currently, too many issues open, so this library is getting messy (see the pull requests which hasn't been processed for a long time).

@johncblandii
Copy link

@trepidity that's clearer. If I get enough free time, I'll push a PR.

@ohtangza feel free to focus on stabilization. Just when network playback becomes a feature the natural next step is streaming audio (either via progressive download or otherwise). Labeling it as help wanted is a great step forward to getting the help from those of us in the community capable of such a rewrite.

@ohtangza
Copy link

@johncblandii Thanks for your prompt input on this. As you said, we'd like to make it clear somewhere in docs about the directions. Please understand that this is not a judgment on whether the feature is important or not. It's just not a trivial work because we need to change the core part of this library as @trepidity commented. If you submit a pull request to implement streaming, my team would be happy to review it because we could enhance our user's experience to a certain degree :)

In the meantime, react-native-audio-toolkit could be your second choice because it supports streaming very well in ios and android when we prototyped with this library earlier.

@johncblandii
Copy link

No problem, @ohtangza. I get where you guys are coming from for sure.

@eis
Copy link

eis commented Aug 20, 2018

Regarding react-native-audio-toolkit, it seems they have a problem of not being maintained either (react-native-audio-toolkit/react-native-audio-toolkit#83) and they don't seem to support local playback in ios, which is kinda important (SOURCES.md, react-native-audio-toolkit/react-native-audio-toolkit#97)

@dmathewwws
Copy link

If you are looking for other options, there is also https://github.com/react-native-kit/react-native-track-player which supports streaming

@RamanSB
Copy link

RamanSB commented Nov 1, 2023

If you are looking for other options, there is also https://github.com/react-native-kit/react-native-track-player which supports streaming

Curious to know how this performed for everybody?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants