-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't Render Fully Qualified Name in Default Debug Renderer #72
Comments
ill do it |
Awesome! |
Merged
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the default renderer for
Debug
renders the fully qualified name of each constructor. So for example aValidation
instance would be rendered aszio.prelude.Validation.Failure(zio.Chunk("some string"))
whereas the rendering given bytoString
would beFailure(Chunk("some string"))
. While valid and perhaps optimal for compiling the rendering back to Scala, this is not the best default as it can lead to cluttered output when the constructor is deeply nested and inconsistent behavior depending on whether the user callsdebug.render
andtoString
even for user created types.We should change the default renderer to render to unqualified name and add an additional renderer to render the fully qualified name. We can then test that the default rendering is equivalent to
toString
for all standard types.The text was updated successfully, but these errors were encountered: