zio.json.ast.Json.as[X] does not support nullable/Option fields

[GiGurra]

ast Json as method does not respect nullable fields. Instead of decoding to option it produces decoding error.

Example:

case class SomeClass(a: Int, b: Option[String])
object SomeClass:
  given JsonCodec[SomeClass] = DeriveJsonCodec.gen[SomeClass]

val start = SomeClass(1, None)
println(start)
println(start.toJson)
val back = start.toJson.fromJson[SomeClass]
val backAst = start.toJson.fromJson[Json]
println(back)
println(backAst)
println(backAst.flatMap(ast => ast.toJson.fromJson[SomeClass]))
println(backAst.flatMap(_.as[SomeClass]))

Prints

SomeClass(1,None)
{"a":1}
Right(SomeClass(1,None))
Right({"a":1})
Right(SomeClass(1,None))
Left(Missing fields: b) // WRONG

[loicdescotte]

It seems ok like this (using last RC) :

import zio.json._

case class SomeClass(a: Int, b: Option[String])
object SomeClass :
  given JsonCodec[SomeClass] = DeriveJsonCodec.gen[SomeClass]

val start = SomeClass(1, None)
println(start)

val back = start.toJson
println(back)
println(back.fromJson[SomeClass])

Prints:

SomeClass(1,None)
{"a":1}
Right(SomeClass(1,None))

[GiGurra]

@loicdescotte Your test does not extract/map/deserialize from the json ast. back in your case is just a string.

The issue is still there in the current/latest RC (0.3.0-RC11 and 0.3.0-RC11+7-12139a3d-SNAPSHOT)

you can verify this yourself by simply adding the last two lines of this to your own test code:

import zio.json._
case class SomeClass(a: Int, b: Option[String])
object SomeClass:
  given JsonCodec[SomeClass] = DeriveJsonCodec.gen[SomeClass]

val start = SomeClass(1, None)
println(start)

val back = start.toJson
println(back)
println(back.fromJson[SomeClass])

val backAst = start.toJsonAST
println(backAst.flatMap(_.as[SomeClass])) // fails

[ex0ns]

I ended up having a similar problem, but only in Scala 3, according to the syntax you used I guess this is you case too, #781 should solve that

[guizmaii]

@GiGurra @loicdescotte @ex0ns Is this fixed now?

[ex0ns]

https://github.com/zio/zio-json/blob/series/2.x/zio-json/shared/src/test/scala/zio/json/DecoderSpec.scala#L130 is still passing so I guess it does, I have to say that I don't even remember why I needed that or if I even used it after fixing, but in theory, that should work

[guizmaii]

@fsvehla I think we can close this issue