Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuggestTypeAlias is missing a dot #463

Closed
nafg opened this issue Dec 26, 2023 · 7 comments · Fixed by #464
Closed

SuggestTypeAlias is missing a dot #463

nafg opened this issue Dec 26, 2023 · 7 comments · Fixed by #464

Comments

@nafg
Copy link

nafg commented Dec 26, 2023

I'm getting things like zioURIO[.... There should be a dot between zio and the alias.

@hmemcpy
Copy link
Collaborator

hmemcpy commented Dec 26, 2023

ugh. I hadn't encountered it. Can you paste a small snippet where you're trying to invoke this refactoring?
Also, is this Scala 2 or 3? and what ZIO version?

@nafg
Copy link
Author

nafg commented Dec 26, 2023

Scala 2, ZIO 2.x

I don't have a snippet this second but it was consistent. I think it was on method return types.

@hmemcpy
Copy link
Collaborator

hmemcpy commented Dec 26, 2023

Cheers, I'll take a look. Thanks!

@hmemcpy
Copy link
Collaborator

hmemcpy commented Dec 26, 2023

I was able to reproduce this, going e.g. from ZIO[Any, Exception, Unit] to IO[Exception, Unit] in both ZIO 1 and ZIO 2 projects. Hmm. Let's see...

@hmemcpy
Copy link
Collaborator

hmemcpy commented Dec 26, 2023

A quick look suggests that the canonical text for the type alias returns _root_.zioIO for some reason. This is from the Scala plugin itself, they may have introduced a bug. Will have to bisect. sigh

@hmemcpy
Copy link
Collaborator

hmemcpy commented Dec 26, 2023

Well, I found the relevant change in the Scala plugin (JetBrains/intellij-scala@0669994). Will continue after the holidays to figure out what/why it was changed. Will try to think of a hack as a workaround in the meantime...

@hmemcpy
Copy link
Collaborator

hmemcpy commented Dec 26, 2023

Welp, in the meantime I've merged in a hack. This should be available later in the EAP channel. I'll see if I get a better answer from the JetBrains folks regarding solving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants